user agent - Newbie to Javascript: iOS, Android, or Desktop Javascript Optimization -


i have been getting javascript. not lot, i'd optimization , tips on if there'd better way handle script:

    <script type="text/javascript">     function fnisapplemobile()      {        if (navigator && navigator.useragent && navigator.useragent != null)         {         var struseragent = navigator.useragent.tolowercase();         var arrmatches = struseragent.match(/(iphone|ipod|ipad)/);         var arrmatches2 = struseragent.match(/(android)/);         if (arrmatches) {              document.write("<b>you on ios!</b>"); }         else if (arrmatches2) {              document.write("<b>you on android!</b>"); }         else {               document.write("<b>you on computer.</b>")}        }     }  var bisapplemobile = fnisapplemobile(); </script>

the way script ends cannot optimal. advice?

thank patience.

a function use it, should return value. in case might thing you're expecting boolean more specific.

you improve code this:

<script type="text/javascript"> function fnisapplemobile()  {    var blnreturn = false;     if (navigator && navigator.useragent && navigator.useragent != null)     {     var struseragent = navigator.useragent.tolowercase();     var arrmatches = struseragent.match(/(iphone|ipod|ipad)/);     if (arrmatches) {          blnreturn = true;     }    }     // true if apple mobile; false if it's     return blnreturn; }  // store in variable var bisapplemobile = fnisapplemobile();  // or use directly need it: if (fnisapplemobile()) {     alert("cool gadget"); } </script>

my advise; never use document.write. not when you're dealing dom @ least. if need output text, try output text inside dom node.


Comments

Post a Comment

Popular posts from this blog

node.js - Bad Request - node js ajax post -

i'm using express 3.0 , node v0.11.0. have button submits form , i'm using ajax post data json object node server. client code is: $('#contact').submit(function(e) { console.log('submit called'); var formdata = json.stringify($('form').serializeobject()); console.log(formdata); $.ajax({ url: "http://localhost:3000/savedata/", type: "post", datatype: 'json', data: {objectdata: formdata}, contenttype: "application/json", complete: function() { console.log('process complete'); }, success: function(data) { console.log('process sucess'); }, error: function() { console.log('process error'); }, }); return false; }); then on server: var express = require('express'); var app = express(); app.set('views', __dirname + '/views'); app.set('view engine', 'jade'); app.use(express.bodyparser());...
Read more

Why does Ruby on Rails generate add a blank line to the end of a file? -

running rails generate controller foo home results in: class foocontroller < application controller def home end end (there's nothing on line in actual file, blank line) is there purpose blank line? it's common use newline indicate end of line, last line. many editors (like vi, use) add in newline silently. consensus text files (especially in unix world) should end in newline, , there have been problems historically if wasn't present. why should text files end newline? the tool used count lines in file "wc" counts newlines in file, without trailing newline show 3 instead of 4. it improves readability of templates used in generator. consider: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/controller/templates/controller.rb to remove trailing newline, template have last line of: end<% end -%> instead of: end <% end -%> that seems less readable me. the discussion below refers ...
Read more

keyboard - Smiles and long press feature in Android -

i've created android keyboard. how add features inserting smilies, , using long keypresses display symbols? to create long-press behavior allows select several options pop-up menu, follow guide (specifically pop-up menu section): http://developer.android.com/guide/topics/ui/menus.html smileys (also known emoticons) combination of keys, understood programs , parsed same way. have do, when clicks smiley face on keyboard, simulate pressing of key combination matching emoticon. example, when clicks smiley, should simulate key presses ':' , ')' :). here's list of emoticons: http://en.wikipedia.org/wiki/list_of_emoticons
Read more